Page MenuHomePhabricator
Differential D21154

Entirely replace the old filetree UI with the "flank" UI
ClosedPublic
Actions

Authored by epriestley on Apr 21 2020, 10:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 22, 3:59 AM
Unknown Object (File)
Thu, Nov 21, 8:39 PM
Unknown Object (File)
Sat, Nov 2, 12:21 PM
Unknown Object (File)
Oct 16 2024, 12:37 AM
Unknown Object (File)
Oct 11 2024, 3:57 PM
Unknown Object (File)
Oct 7 2024, 3:08 AM
Unknown Object (File)
Sep 17 2024, 10:51 AM
Unknown Object (File)
Sep 15 2024, 12:13 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13516: Remove the "filetree" setting (so it's always enabled for everyone)
Commits
rP12eddb18fb78: Entirely replace the old filetree UI with the "flank" UI
Summary

Ref T13516. Deletes all old filetree / flex / active / collapse nav code in favor of the new code.

Restores the inline tips in the path tree.

Test Plan

Screen Shot 2020-04-21 at 3.18.06 PM.png (1×1 px, 539 KB)

Diff Detail

Repository
rP Phabricator
Branch
flank5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24181
Build 33306: Run Core Tests
Build 33305: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 21 2020, 10:21 PM
Harbormaster completed remote builds in B24181: Diff 50363.Apr 21 2020, 10:23 PM
epriestley requested review of this revision.Apr 21 2020, 10:23 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 22 2020, 3:32 PM
Closed by commit rP12eddb18fb78: Entirely replace the old filetree UI with the "flank" UI (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP12eddb18fb78: Entirely replace the old filetree UI with the "flank" UI.

Revision Contents
Changeset List

Diff 50363

View Options

resources/celerity/map.php

Loading...
View Options

resources/celerity/packages.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/view/DifferentialChangesetDetailView.php

Loading...
View Options

src/applications/differential/view/DifferentialChangesetFileTreeSideNavBuilder.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionCommitController.php

Loading...
View Options

src/applications/settings/setting/PhabricatorShowFiletreeSetting.php

Loading...
View Options

src/view/layout/AphrontSideNavFilterView.php

Loading...
View Options

webroot/rsrc/css/aphront/phabricator-nav-view.css

Loading...
View Options

webroot/rsrc/css/application/base/standard-page-view.css

Loading...
View Options

webroot/rsrc/css/application/diff/diff-tree-view.css

Loading...
View Options

webroot/rsrc/css/core/z-index.css

Loading...
View Options

webroot/rsrc/css/layout/phabricator-filetree-view.css

Loading...
View Options

webroot/rsrc/js/application/diff/DiffChangeset.js

Loading...
View Options

webroot/rsrc/js/application/diff/DiffChangesetList.js

Loading...
View Options

webroot/rsrc/js/application/diff/DiffPathView.js

Loading...
View Options

webroot/rsrc/js/core/behavior-active-nav.js

Loading...
View Options

webroot/rsrc/js/core/behavior-file-tree.js

Loading...
View Options

webroot/rsrc/js/core/behavior-phabricator-nav.js

Loading...
Phabricator · Built by Phacility