Differential D21154

Entirely replace the old filetree UI with the "flank" UI
ClosedPublic
Actions

Authored by epriestley on Apr 21 2020, 10:21 PM.

Details

Reviewers: None
Maniphest Tasks: T13516: Remove the "filetree" setting (so it's always enabled for everyone)
Commits: rP12eddb18fb78: Entirely replace the old filetree UI with the "flank" UI

Summary

Ref T13516. Deletes all old filetree / flex / active / collapse nav code in favor of the new code.

Restores the inline tips in the path tree.

Test Plan

Screen Shot 2020-04-21 at 3.18.06 PM.png (1×1 px, 539 KB)

Diff Detail

Repository

rP Phabricator

Branch

flank5

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24181
Build 33306: Run Core Tests
Build 33305: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 21 2020, 10:21 PM

Harbormaster completed remote builds in B24181: Diff 50363.Apr 21 2020, 10:23 PM

epriestley requested review of this revision.Apr 21 2020, 10:23 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 22 2020, 3:32 PM

Closed by commit rP12eddb18fb78: Entirely replace the old filetree UI with the "flank" UI (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP12eddb18fb78: Entirely replace the old filetree UI with the "flank" UI.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

packages.php

3 lines

src/

__phutil_library_map__.php

applications/

differential/

view/

DifferentialChangesetDetailView.php

1 line

DifferentialChangesetFileTreeSideNavBuilder.php

diffusion/

controller/

DiffusionCommitController.php

44 lines

settings/

setting/

PhabricatorShowFiletreeSetting.php

view/

layout/

AphrontSideNavFilterView.php

91 lines

webroot/

rsrc/

css/

aphront/

phabricator-nav-view.css

56 lines

application/

base/

standard-page-view.css

9 lines

diff/

diff-tree-view.css

34 lines

core/

z-index.css

4 lines

layout/

phabricator-filetree-view.css

js/

application/

diff/

DiffChangeset.js

17 lines

DiffChangesetList.js

7 lines

DiffPathView.js

20 lines

core/

behavior-active-nav.js

behavior-file-tree.js

behavior-phabricator-nav.js

Diff 50363

View Options

resources/celerity/map.php

View Options

resources/celerity/packages.php

View Options

src/__phutil_library_map__.php

View Options

src/applications/differential/view/DifferentialChangesetDetailView.php

View Options

src/applications/differential/view/DifferentialChangesetFileTreeSideNavBuilder.php

View Options

src/applications/diffusion/controller/DiffusionCommitController.php

View Options

src/applications/settings/setting/PhabricatorShowFiletreeSetting.php

View Options

src/view/layout/AphrontSideNavFilterView.php

View Options

webroot/rsrc/css/aphront/phabricator-nav-view.css

View Options

webroot/rsrc/css/application/base/standard-page-view.css

View Options

webroot/rsrc/css/application/diff/diff-tree-view.css

View Options

webroot/rsrc/css/core/z-index.css

View Options

webroot/rsrc/css/layout/phabricator-filetree-view.css

View Options

webroot/rsrc/js/application/diff/DiffChangeset.js

View Options

webroot/rsrc/js/application/diff/DiffChangesetList.js

View Options

webroot/rsrc/js/application/diff/DiffPathView.js

View Options

webroot/rsrc/js/core/behavior-active-nav.js

View Options

webroot/rsrc/js/core/behavior-file-tree.js

View Options

webroot/rsrc/js/core/behavior-phabricator-nav.js

Entirely replace the old filetree UI with the "flank" UIClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 50363

resources/celerity/map.php

resources/celerity/packages.php

src/__phutil_library_map__.php

src/applications/differential/view/DifferentialChangesetDetailView.php

src/applications/differential/view/DifferentialChangesetFileTreeSideNavBuilder.php

src/applications/diffusion/controller/DiffusionCommitController.php

src/applications/settings/setting/PhabricatorShowFiletreeSetting.php

src/view/layout/AphrontSideNavFilterView.php

webroot/rsrc/css/aphront/phabricator-nav-view.css

webroot/rsrc/css/application/base/standard-page-view.css

webroot/rsrc/css/application/diff/diff-tree-view.css

webroot/rsrc/css/core/z-index.css

webroot/rsrc/css/layout/phabricator-filetree-view.css

webroot/rsrc/js/application/diff/DiffChangeset.js

webroot/rsrc/js/application/diff/DiffChangesetList.js

webroot/rsrc/js/application/diff/DiffPathView.js

webroot/rsrc/js/core/behavior-active-nav.js

webroot/rsrc/js/core/behavior-file-tree.js

webroot/rsrc/js/core/behavior-phabricator-nav.js

Entirely replace the old filetree UI with the "flank" UI
ClosedPublic
Actions

Revision Contents
Changeset List