Page MenuHomePhabricator

Add ref lookup for username symbols
ClosedPublic

Authored by epriestley on Apr 12 2020, 3:05 PM.
Tags
None
Referenced Files
F13239561: D21092.id.diff
Wed, May 22, 4:37 AM
F13225219: D21092.diff
Sun, May 19, 2:04 PM
F13205482: D21092.diff
Wed, May 15, 1:59 AM
F13199034: D21092.diff
Mon, May 13, 11:07 AM
F13189165: D21092.diff
Sat, May 11, 5:45 AM
Unknown Object (File)
Tue, May 7, 9:35 AM
Unknown Object (File)
May 5 2024, 12:42 AM
Unknown Object (File)
May 3 2024, 9:24 AM
Subscribers
None

Details

Summary

Ref T13490. I'm attempting to update "arc amend", but it needs to fetch revision authors to raise an "amending a revision you don't own" error.

Support user-symbol resolution.

Along the way, this introduces some infrastructure for abstracting away iteration over a multi-page Conduit result set.

Test Plan
  • Ran "arc inspect ..." for various "user(...)" queries.
  • Set page size to 3 and issued a general query, saw the future page it away properly.

Diff Detail

Repository
rARC Arcanist
Branch
aflow7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24053
Build 33114: Run Core Tests
Build 33113: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Apr 12 2020, 8:42 PM
This revision was automatically updated to reflect the committed changes.