Page MenuHomePhabricator

Add ref lookup for username symbols
ClosedPublic

Authored by epriestley on Apr 12 2020, 3:05 PM.
Tags
None
Referenced Files
F15487063: D21092.id50235.diff
Thu, Apr 10, 10:55 AM
F15476441: D21092.diff
Mon, Apr 7, 6:07 AM
F15441135: D21092.id50245.diff
Wed, Mar 26, 4:39 PM
F15440586: D21092.id50235.diff
Wed, Mar 26, 1:39 PM
F15438096: D21092.id.diff
Tue, Mar 25, 11:22 PM
F15431628: D21092.diff
Mon, Mar 24, 1:37 PM
F15407546: D21092.id.diff
Mar 18 2025, 6:14 PM
F15337661: D21092.diff
Mar 9 2025, 7:01 AM
Subscribers
None

Details

Summary

Ref T13490. I'm attempting to update "arc amend", but it needs to fetch revision authors to raise an "amending a revision you don't own" error.

Support user-symbol resolution.

Along the way, this introduces some infrastructure for abstracting away iteration over a multi-page Conduit result set.

Test Plan
  • Ran "arc inspect ..." for various "user(...)" queries.
  • Set page size to 3 and issued a general query, saw the future page it away properly.

Diff Detail

Repository
rARC Arcanist
Branch
aflow7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24053
Build 33114: Run Core Tests
Build 33113: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Apr 12 2020, 8:42 PM
This revision was automatically updated to reflect the committed changes.