Page MenuHomePhabricator

Add ref lookup for username symbols
ClosedPublic

Authored by epriestley on Apr 12 2020, 3:05 PM.
Tags
None
Referenced Files
F19083246: D21092.id50245.diff
Dec 2 2025, 12:32 PM
F18985403: D21092.id50235.diff
Nov 17 2025, 1:01 PM
F18885074: D21092.diff
Nov 7 2025, 2:38 AM
F18852897: D21092.id50235.diff
Oct 31 2025, 12:49 PM
F18825374: D21092.id.diff
Oct 23 2025, 9:26 PM
F18820095: D21092.diff
Oct 22 2025, 12:31 PM
F18757324: D21092.id50245.diff
Oct 5 2025, 4:54 PM
F18734212: D21092.id.diff
Sep 30 2025, 10:50 PM
Subscribers
None

Details

Summary

Ref T13490. I'm attempting to update "arc amend", but it needs to fetch revision authors to raise an "amending a revision you don't own" error.

Support user-symbol resolution.

Along the way, this introduces some infrastructure for abstracting away iteration over a multi-page Conduit result set.

Test Plan
  • Ran "arc inspect ..." for various "user(...)" queries.
  • Set page size to 3 and issued a general query, saw the future page it away properly.

Diff Detail

Repository
rARC Arcanist
Branch
aflow7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24053
Build 33114: Run Core Tests
Build 33113: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Apr 12 2020, 8:42 PM
This revision was automatically updated to reflect the committed changes.