Page MenuHomePhabricator
Differential D21088

Allow "loadHardpoints()" to accept a single ref and/or a single hardpoint
ClosedPublic
Actions

Authored by epriestley on Apr 11 2020, 10:32 PM.
Tags
None
Referenced Files
F15437462: D21088.id.diff
Tue, Mar 25, 7:34 PM
F15429985: D21088.diff
Mon, Mar 24, 5:10 AM
F15424301: D21088.diff
Sat, Mar 22, 9:20 PM
F15423809: D21088.id50241.diff
Sat, Mar 22, 6:30 PM
F15419718: D21088.diff
Fri, Mar 21, 8:21 AM
Unknown Object (File)
Sun, Mar 2, 9:01 PM
Unknown Object (File)
Feb 23 2025, 3:56 AM
Unknown Object (File)
Feb 16 2025, 5:40 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13490: Upgrade all "classic" Arcanist workflows to Toolsets
Commits
rARC73f48aca7409: Allow "loadHardpoints()" to accept a single ref and/or a single hardpoint
Summary

Ref T13490. There's more array(...) happening in this API than necessary. Sugar it slightly.

Test Plan

Grepped for "loadHardpoints()", ran a couple workflows.

Diff Detail

Repository
rARC Arcanist
Branch
aflow3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24048
Build 33104: Run Core Tests
Build 33103: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 11 2020, 10:32 PM
Harbormaster completed remote builds in B24048: Diff 50230.Apr 11 2020, 10:32 PM
epriestley requested review of this revision.Apr 11 2020, 10:32 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 12 2020, 8:17 PM
Closed by commit rARC73f48aca7409: Allow "loadHardpoints()" to accept a single ref and/or a single hardpoint (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rARC73f48aca7409: Allow "loadHardpoints()" to accept a single ref and/or a single hardpoint.

Revision Contents
Changeset List

Diff 50230

View Options

src/browse/workflow/ArcanistBrowseWorkflow.php

Loading...
View Options

src/workflow/ArcanistDiffWorkflow.php

Loading...
View Options

src/workflow/ArcanistFeatureBaseWorkflow.php

Loading...
View Options

src/workflow/ArcanistInspectWorkflow.php

Loading...
View Options

src/workflow/ArcanistWorkflow.php

Loading...
Phabricator · Built by Phacility