Page MenuHomePhabricator

Update some Phabricator behaviors for changes to Futures
ClosedPublic

Authored by epriestley on Apr 3 2020, 7:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 5, 1:51 AM
Unknown Object (File)
Feb 3 2024, 11:53 PM
Unknown Object (File)
Jan 9 2024, 4:37 PM
Unknown Object (File)
Dec 29 2023, 1:25 AM
Unknown Object (File)
Dec 28 2023, 2:06 AM
Unknown Object (File)
Dec 25 2023, 6:03 PM
Unknown Object (File)
Dec 24 2023, 5:02 PM
Unknown Object (File)
Dec 21 2023, 8:35 PM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D21053. Ref T11968. Three things have changed:

  • Overseers can no longer use FutureIterator to continue execution of an arbitrary list of futures from any state. Use FuturePool instead.
  • Same with repository daemons.
  • Probably (?) fix an API change in the Harbormaster exec future.
Test Plan
  • Ran "bin/phd debug task" and "bin/phd debug pull", no longer saw Future-management related errors.
  • The Harbormaster future is easiest to test by just seeing if production works once this change is deployed there.

Diff Detail

Repository
rP Phabricator
Branch
future1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23981
Build 33004: Run Core Tests
Build 33003: arc lint + arc unit

Event Timeline

Owners added a subscriber: Restricted Owners Package.Apr 3 2020, 7:03 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Apr 3 2020, 7:04 PM
Harbormaster failed remote builds in B23977: Diff 50158!
  • Rebase on "ini_set" unit test fix.
This revision was not accepted when it landed; it landed in state Needs Review.Apr 3 2020, 7:27 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.