Differential D21054

Update some Phabricator behaviors for changes to Futures
ClosedPublic
Actions

Authored by epriestley on Apr 3 2020, 7:03 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Nov 19, 10:15 PM

	Unknown Object (File)
	Sat, Nov 16, 2:23 PM

	Unknown Object (File)
	Mon, Nov 11, 7:19 PM

	Unknown Object (File)
	Fri, Nov 8, 7:53 AM

	Unknown Object (File)
	Mon, Nov 4, 5:16 PM

	Unknown Object (File)
	Sun, Nov 3, 11:48 PM

	Unknown Object (File)
	Fri, Nov 1, 8:45 PM

	Unknown Object (File)
	Sun, Oct 27, 8:40 AM

Subscribers

Restricted Owners Package

Details

Reviewers: None
Maniphest Tasks: T11968: Decide the fate of FutureGraph
Commits: rP1a59cae743c2: Update some Phabricator behaviors for changes to Futures

Summary

Depends on D21053. Ref T11968. Three things have changed:

Overseers can no longer use FutureIterator to continue execution of an arbitrary list of futures from any state. Use FuturePool instead.
Same with repository daemons.
Probably (?) fix an API change in the Harbormaster exec future.

Test Plan

Ran "bin/phd debug task" and "bin/phd debug pull", no longer saw Future-management related errors.
The Harbormaster future is easiest to test by just seeing if production works once this change is deployed there.

Diff Detail

Repository

Branch

future1

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/harbormaster/future/HarbormasterExecFuture.php:51	XHP16	TODO Comment
Advice	src/infrastructure/daemon/PhutilDaemonOverseer.php:217	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 23977
Build 32998: Run Core Tests
Build 32997: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	0 ms	AphrontHTTPSinkTestCase::testJSONContentSniff EXCEPTION (RuntimeException): ini_set(): Cannot change zlib.output_compression - headers already sent #0 [internal function]: PhutilErrorHandler::handleError(2, 'ini_set(): Cann...', '/core/data/dryd...', 424, Array) #1 /core/data/drydock/workingcopy-85/repo/phabricator/src/aphront/response/AphrontResponse.php(424): ini_set('zlib.output_com...', '1')
	0 ms	AlmanacNamesTestCase::testServiceOrDeviceNames 30 assertions passed.
	0 ms	AlmanacServiceTypeTestCase::testGetAllServiceTypes 1 assertion passed.
	0 ms	AphrontHTTPHeaderParserTestCase::testHeaderParser 18 assertions passed.
	0 ms	AphrontHTTPSinkTestCase::testHTTPHeaderNames 2 assertions passed.
		View Full Test Results (1 Failed · 427 Passed · 2 Skipped)

Event Timeline

epriestley created this revision.Apr 3 2020, 7:03 PM

Owners added a subscriber: Restricted Owners Package.Apr 3 2020, 7:03 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 3 2020, 7:04 PM

Harbormaster failed remote builds in B23977: Diff 50158!

Rebase on "ini_set" unit test fix.

Harbormaster completed remote builds in B23981: Diff 50162.Apr 3 2020, 7:27 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 3 2020, 7:27 PM

epriestley requested review of this revision.

Closed by commit rP1a59cae743c2: Update some Phabricator behaviors for changes to Futures (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP1a59cae743c2: Update some Phabricator behaviors for changes to Futures.

Revision Contents
Changeset List

Path

Size

src/

applications/

harbormaster/

future/

HarbormasterExecFuture.php

17 lines

repository/

daemon/

PhabricatorRepositoryPullLocalDaemon.php

34 lines

infrastructure/

daemon/

PhutilDaemonOverseer.php

41 lines

Diff 50158

src/applications/harbormaster/future/HarbormasterExecFuture.php

Loading...

src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php

Loading...

src/infrastructure/daemon/PhutilDaemonOverseer.php

Loading...