Page MenuHomePhabricator

Do not count hidden changesets as changed changesets during diff comparison
AbandonedPublic

Authored by epriestley on Apr 2 2020, 12:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 12:44 PM
Unknown Object (File)
Fri, Nov 22, 4:42 AM
Unknown Object (File)
Fri, Nov 22, 4:41 AM
Unknown Object (File)
Tue, Nov 19, 11:47 AM
Unknown Object (File)
Sun, Nov 17, 2:10 PM
Unknown Object (File)
Sun, Nov 17, 9:20 AM
Unknown Object (File)
Sun, Nov 17, 6:16 AM
Unknown Object (File)
Sat, Nov 16, 11:43 PM
Subscribers

Details

Reviewers
Pawka
artms
Group Reviewers
Blessed Reviewers
Summary

Phabricator will bailout to compare diff changes in revision even though changes between diffs was small

Test Plan

Compared diffs in revision which has +1k files changed but diff between changeset is actually small - saw difference instead of warning that This very large diff affects more than 1,000 files. Use the Changeset List to browse changes.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 23967
Build 32981: Run Core Tests
Build 32980: arc lint + arc unit

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 2 2020, 12:18 PM
Harbormaster failed remote builds in B23967: Diff 50148!
src/applications/differential/controller/DifferentialRevisionViewController.php
16

We also can substract hidden changesets here instead of setting changeset size artificially smaller...

Tests failed due to:

PHP Fatal error:  Cannot override final method Future::getResult() in /core/data/drydock/workingcopy-89/repo/phabricator/src/applications/harbormaster/future/HarbormasterExecFuture.php on line 50

Looks like some broken refactoring?

artms edited the summary of this revision. (Show Details)
artms edited the summary of this revision. (Show Details)
artms edited the summary of this revision. (Show Details)
artms edited the summary of this revision. (Show Details)
artms edited the summary of this revision. (Show Details)
artms requested review of this revision.Nov 6 2020, 7:07 PM
epriestley abandoned this revision.
epriestley edited reviewers, added: artms; removed: epriestley.

Please file bug reports via Discourse or, if applicable, your organization's support channel.