Do not count hidden changesets as changed changesets during diff comparison
AbandonedPublic
Actions

Authored by epriestley on Apr 2 2020, 12:18 PM.

Details

Reviewers

Pawka
artms

Group Reviewers

Blessed Reviewers

Summary

Phabricator will bailout to compare diff changes in revision even though changes between diffs was small

Test Plan

Compared diffs in revision which has +1k files changed but diff between changeset is actually small - saw difference instead of warning that This very large diff affects more than 1,000 files. Use the Changeset List to browse changes.

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 23967
Build 32981: Run Core Tests
Build 32980: arc lint + arc unit

Event Timeline

artms created this revision.Apr 2 2020, 12:18 PM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 2 2020, 12:18 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 2 2020, 12:18 PM

Harbormaster failed remote builds in B23967: Diff 50148!

artms added inline comments.Apr 2 2020, 12:18 PM

src/applications/differential/controller/DifferentialRevisionViewController.php
16	We also can substract hidden changesets here instead of setting changeset size artificially smaller...

Tests failed due to:

PHP Fatal error:  Cannot override final method Future::getResult() in /core/data/drydock/workingcopy-89/repo/phabricator/src/applications/harbormaster/future/HarbormasterExecFuture.php on line 50

Looks like some broken refactoring?

artms edited the summary of this revision. (Show Details)Apr 7 2020, 10:37 AM

artms edited the summary of this revision. (Show Details)

artms edited the summary of this revision. (Show Details)Apr 7 2020, 10:41 AM

artms edited the summary of this revision. (Show Details)

artms edited the summary of this revision. (Show Details)Apr 7 2020, 10:45 AM

artms edited the summary of this revision. (Show Details)