Paths

Table of Contentst

Differential D21045

Run ls-files from the root of the directory
ClosedPublic
Actions

Authored by ptarjan on Mar 25 2020, 8:45 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC33b9728b5f65: Run ls-files from the root of the directory

Summary

One of our users ran into an issue where they were running arc diff in
a subdirectory and it so happened that in that directoy there wasn't any lfs
files so the repo was marked as $is_lfs == false. Lets allow arc to be run
from anywhere.

Test Plan

Internally this patch worked

Diff Detail

Repository

rARC Arcanist

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23955
Build 32966: arc lint + arc unit

Event Timeline

ptarjan created this revision.Mar 25 2020, 8:45 PM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMar 25 2020, 8:45 PM

ptarjan requested review of this revision.Mar 25 2020, 8:45 PM

Herald added a subscriber: Korvin. · View Herald TranscriptMar 25 2020, 8:45 PM

Harbormaster completed remote builds in B23954: Diff 50135.Mar 25 2020, 8:45 PM

Try something like this:

list($stdout) = $repository_api->execxLocal(
  'ls-files ...',
  ':(attr...)');

That should set the CWD correctly and avoid a bunch of other issues (see T13479). We also likely can't $(...) on Windows.

This revision now requires changes to proceed.Mar 25 2020, 8:49 PM

(Actual change makes perfect sense.)

If that doesn't immediately work, yell at me and I can grab this and figure out what's up.

use repository api

Harbormaster completed remote builds in B23955: Diff 50136.Mar 25 2020, 9:06 PM

ptarjan edited the summary of this revision. (Show Details)Mar 25 2020, 9:12 PM

ptarjan edited the summary of this revision. (Show Details)

Thanks!

This revision is now accepted and ready to land.Mar 25 2020, 9:13 PM

Closed by commit rARC33b9728b5f65: Run ls-files from the root of the directory (authored by ptarjan). · Explain WhyMar 25 2020, 9:23 PM

This revision was automatically updated to reflect the committed changes.

ptarjan added a commit: rARC33b9728b5f65: Run ls-files from the root of the directory.

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistDiffWorkflow.php

2 lines

Diff 50136

View Options

src/workflow/ArcanistDiffWorkflow.php

Run ls-files from the root of the directoryClosedPublicActions