Page MenuHomePhabricator

Run ls-files from the root of the directory
ClosedPublic

Authored by ptarjan on Mar 25 2020, 8:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 20, 4:07 AM
Unknown Object (File)
Mon, Mar 4, 4:57 PM
Unknown Object (File)
Feb 15 2024, 2:32 PM
Unknown Object (File)
Feb 3 2024, 11:51 PM
Unknown Object (File)
Dec 26 2023, 5:59 PM
Unknown Object (File)
Dec 24 2023, 4:40 AM
Unknown Object (File)
Dec 22 2023, 9:30 PM
Unknown Object (File)
Dec 22 2023, 8:28 PM
Subscribers

Details

Summary

One of our users ran into an issue where they were running arc diff in
a subdirectory and it so happened that in that directoy there wasn't any lfs
files so the repo was marked as $is_lfs == false. Lets allow arc to be run
from anywhere.

Test Plan

Internally this patch worked

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23955
Build 32966: arc lint + arc unit

Event Timeline

Try something like this:

list($stdout) = $repository_api->execxLocal(
  'ls-files ...',
  ':(attr...)');

That should set the CWD correctly and avoid a bunch of other issues (see T13479). We also likely can't $(...) on Windows.

This revision now requires changes to proceed.Mar 25 2020, 8:49 PM

(Actual change makes perfect sense.)

If that doesn't immediately work, yell at me and I can grab this and figure out what's up.

ptarjan edited the summary of this revision. (Show Details)
ptarjan edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Mar 25 2020, 9:13 PM