Switch file uploader in "arc diff" to use ConduitEngine
ClosedPublic
Actions

Authored by epriestley on Mar 20 2020, 7:18 PM.

Details

Reviewers: None
Maniphest Tasks: T13498: "arc diff" may fail with Toolsets code when trying to build a ConduitEngine to upload files
Commits: rARC18799c182921: Switch file uploader in "arc diff" to use ConduitEngine

Summary

Fixes T13498. Currently, arc diff may invoke the file upload flow using an older variation of the API. Both the modern and fallback clients build an Engine, so switching to the modern API is trivial.

Test Plan

Created a local commit with a 1MB binary file.
Ran arc diff --only.
Before patch: fatal on old API call.
After patch: clean upload.

Diff Detail

Repository

rARC Arcanist

Branch

upload1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23949
Build 32958: Run Core Tests
Build 32957: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 20 2020, 7:18 PM

Harbormaster completed remote builds in B23949: Diff 50130.Mar 20 2020, 7:19 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 20 2020, 7:19 PM

epriestley requested review of this revision.

Closed by commit rARC18799c182921: Switch file uploader in "arc diff" to use ConduitEngine (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC18799c182921: Switch file uploader in "arc diff" to use ConduitEngine.

Revision Contents
Changeset List

Path

Size

src/

upload/

ArcanistFileUploader.php

4 lines

workflow/

ArcanistDiffWorkflow.php

2 lines

Diff 50130

View Options

src/upload/ArcanistFileUploader.php