Page MenuHomePhabricator

Remove old code for sending email to external users who create objects via inbound mail
ClosedPublic

Authored by epriestley on Feb 20 2020, 8:29 PM.
Tags
None
Referenced Files
F19511256: D21007.diff
Mon, Jan 12, 12:09 AM
F19508825: D21007.diff
Sat, Jan 10, 11:01 AM
F19468801: D21007.id50048.diff
Sun, Jan 4, 10:29 AM
F19468761: D21007.id50052.diff
Sun, Jan 4, 9:43 AM
F19263653: D21007.diff
Mon, Dec 22, 6:19 PM
F19063547: D21007.id50052.diff
Nov 29 2025, 7:16 PM
F19021693: D21007.diff
Nov 23 2025, 7:44 PM
F19009427: D21007.diff
Nov 21 2025, 11:31 PM
Subscribers
None

Details

Summary

Ref T13493. I'm updating callers to getAccountID() to prepare to move it to a separate table.

This callsite once supported this flow:

  • External users with no accounts send mail to bugs@.
  • This creates tasks in Maniphest.
  • They're CC'd when the tasks are updated.

However, after T12237 we never actually send this mail (since their addresses are necessarily unverified).

I left this code in in case this needed to be revisited, but it hasn't been an issue. Just remove it and treat these users as undeliverable.

Test Plan

As a cursory test for nothing being horribly broken, sent some object mail.

Diff Detail

Repository
rP Phabricator
Branch
accountid1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23873
Build 32845: Run Core Tests
Build 32844: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Feb 20 2020, 8:41 PM
This revision was automatically updated to reflect the committed changes.