Page MenuHomePhabricator
Differential D21007

Remove old code for sending email to external users who create objects via inbound mail
ClosedPublic
Actions

Authored by epriestley on Feb 20 2020, 8:29 PM.
Tags
None
Referenced Files
F14854057: D21007.diff
Wed, Feb 5, 7:44 AM
Unknown Object (File)
Sat, Feb 1, 6:34 PM
Unknown Object (File)
Tue, Jan 28, 5:29 AM
Unknown Object (File)
Tue, Jan 28, 5:29 AM
Unknown Object (File)
Tue, Jan 28, 5:29 AM
Unknown Object (File)
Mon, Jan 27, 11:42 PM
Unknown Object (File)
Sat, Jan 25, 10:01 PM
Unknown Object (File)
Sat, Jan 25, 4:39 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13493: JIRA API has changed identifiers from "key" to "accountId"
Commits
rP29923cc71a46: Remove old code for sending email to external users who create objects via…
Summary

Ref T13493. I'm updating callers to getAccountID() to prepare to move it to a separate table.

This callsite once supported this flow:

  • External users with no accounts send mail to bugs@.
  • This creates tasks in Maniphest.
  • They're CC'd when the tasks are updated.

However, after T12237 we never actually send this mail (since their addresses are necessarily unverified).

I left this code in in case this needed to be revisited, but it hasn't been an issue. Just remove it and treat these users as undeliverable.

Test Plan

As a cursory test for nothing being horribly broken, sent some object mail.

Diff Detail

Repository
rP Phabricator
Branch
accountid1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23873
Build 32845: Run Core Tests
Build 32844: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 20 2020, 8:29 PM
Harbormaster completed remote builds in B23873: Diff 50048.Feb 20 2020, 8:30 PM
epriestley requested review of this revision.Feb 20 2020, 8:30 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 20 2020, 8:41 PM
Closed by commit rP29923cc71a46: Remove old code for sending email to external users who create objects via… (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP29923cc71a46: Remove old code for sending email to external users who create objects via….

Revision Contents
Changeset List

PathSize
src/
applications/
metamta/
query/
40 lines

Diff 50048

View Options

src/applications/metamta/query/PhabricatorMetaMTAActorQuery.php

Loading...
Phabricator · Built by Phacility