Page MenuHomePhabricator

Remove old code for sending email to external users who create objects via inbound mail

Authored by epriestley on Feb 20 2020, 8:29 PM.
Referenced Files
F13238885: D21007.diff
Tue, May 21, 10:24 PM
F13231480: D21007.diff
Tue, May 21, 12:30 AM
F13206088: D21007.id50048.diff
Wed, May 15, 5:02 AM
Wed, May 15, 4:52 AM
F13206050: D21007.id50052.diff
Wed, May 15, 4:52 AM
F13185685: D21007.diff
Sat, May 11, 3:08 AM
F13183643: D21007.diff
Fri, May 10, 10:38 AM
Unknown Object (File)
Tue, May 7, 5:36 AM



Ref T13493. I'm updating callers to getAccountID() to prepare to move it to a separate table.

This callsite once supported this flow:

  • External users with no accounts send mail to bugs@.
  • This creates tasks in Maniphest.
  • They're CC'd when the tasks are updated.

However, after T12237 we never actually send this mail (since their addresses are necessarily unverified).

I left this code in in case this needed to be revisited, but it hasn't been an issue. Just remove it and treat these users as undeliverable.

Test Plan

As a cursory test for nothing being horribly broken, sent some object mail.

Diff Detail

rP Phabricator
Lint Not Applicable
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Feb 20 2020, 8:41 PM
This revision was automatically updated to reflect the committed changes.