Differential D21002

Require "--" as an argument terminator when running noninteractively
ClosedPublic
Actions

Authored by epriestley on Feb 15 2020, 6:01 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Feb 9, 8:43 AM

	Unknown Object (File)
	Sun, Feb 9, 8:43 AM

	Unknown Object (File)
	Sun, Feb 9, 8:43 AM

	Unknown Object (File)
	Sat, Feb 1, 4:26 AM

	Unknown Object (File)
	Thu, Jan 30, 2:33 AM

	Unknown Object (File)
	Tue, Jan 28, 5:28 AM

	Unknown Object (File)
	Mon, Jan 27, 10:28 AM

	Unknown Object (File)
	Sat, Jan 25, 1:37 PM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13490: Upgrade all "classic" Arcanist workflows to Toolsets
Commits: rARCd3b77af8a526: Require "--" as an argument terminator when running noninteractively

Summary

Depends on D21001. Ref T13490.

Require "--" to terminate arguments when running noninteractively.
Don't correct spelling when running noninteractively (we still suggest corrections).
Remove old "phage" wrapper script.
Fix an issue where "argv" could implicitly generate a parseable "--argv" flag.
Accept "--" as an argument terminator even when there is no argument list.
Update some strings to use more modern quoting style.
Make workflows decline to handle signals by default.
Allow "arc weld" to weld non-UTF8 files together.

Test Plan

Ran various commands. Welded non-UTF8 files.

Diff Detail

Repository

Branch

fmerge2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23863
Build 32831: Run Core Tests
Build 32830: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 15 2020, 6:01 PM

Harbormaster completed remote builds in B23863: Diff 50037.Feb 15 2020, 6:02 PM

epriestley requested review of this revision.Feb 15 2020, 6:02 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 16 2020, 5:16 PM

Closed by commit rARCd3b77af8a526: Require "--" as an argument terminator when running noninteractively (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARCd3b77af8a526: Require "--" as an argument terminator when running noninteractively.

Revision Contents
Changeset List

Path

Size

scripts/

src/

__phutil_library_map__.php

exception/

ArcanistMissingArgumentTerminatorException.php

4 lines

parser/

argument/

PhutilArgumentParser.php

84 lines

runtime/

ArcanistRuntime.php

31 lines

toolset/

workflow/

ArcanistAliasWorkflow.php

2 lines

utils/

8 lines

workflow/

ArcanistWeldWorkflow.php

16 lines

ArcanistWorkflow.php

4 lines

Diff 50037

scripts/phage.php

Loading...

src/__phutil_library_map__.php

Loading...

src/exception/ArcanistMissingArgumentTerminatorException.php

Loading...

src/parser/argument/PhutilArgumentParser.php

Loading...

src/runtime/ArcanistRuntime.php

Loading...

src/toolset/workflow/ArcanistAliasWorkflow.php

Loading...

src/utils/utils.php

Loading...

src/workflow/ArcanistWeldWorkflow.php

Loading...

src/workflow/ArcanistWorkflow.php

Loading...