Page MenuHomePhabricator

Require "--" as an argument terminator when running noninteractively
ClosedPublic

Authored by epriestley on Feb 15 2020, 6:01 PM.

Details

Summary

Depends on D21001. Ref T13490.

  • Require "--" to terminate arguments when running noninteractively.
  • Don't correct spelling when running noninteractively (we still suggest corrections).
  • Remove old "phage" wrapper script.
  • Fix an issue where "argv" could implicitly generate a parseable "--argv" flag.
  • Accept "--" as an argument terminator even when there is no argument list.
  • Update some strings to use more modern quoting style.
  • Make workflows decline to handle signals by default.
  • Allow "arc weld" to weld non-UTF8 files together.
Test Plan

Ran various commands. Welded non-UTF8 files.

Diff Detail

Repository
rARC Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Feb 15 2020, 6:01 PM
epriestley requested review of this revision.Feb 15 2020, 6:02 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 16 2020, 5:16 PM
This revision was automatically updated to reflect the committed changes.