Differential D21001

Port "arc weld" and "arc anoid" to Toolsets workflows, plus minor fixes
ClosedPublic
Actions

Authored by epriestley on Feb 15 2020, 2:51 AM.

Details

Reviewers: None
Maniphest Tasks: T13490: Upgrade all "classic" Arcanist workflows to Toolsets
Commits: rARCdb8419f19ba2: Port "arc weld" and "arc anoid" to Toolsets workflows, plus minor fixes

Summary

Ref T13490. Update the "weld" workflow and the "anoid" workflow. Incorporates D20938.

Test Plan

Ran "arc weld". Ran "arc anoid".

Diff Detail

Repository

rARC Arcanist

Branch

fmerge1

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/runtime/ArcanistRuntime.php:143	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 23862
Build 32829: Run Core Tests
Build 32828: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 15 2020, 2:51 AM

Harbormaster completed remote builds in B23862: Diff 50036.Feb 15 2020, 2:51 AM

epriestley requested review of this revision.Feb 15 2020, 2:51 AM

epriestley mentioned this in D20938: breakout: migrate to python3.Feb 15 2020, 2:52 AM

epriestley mentioned this in D10671: Force python2 usage.

epriestley added a child revision: D21002: Require "--" as an argument terminator when running noninteractively.Feb 15 2020, 6:01 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 16 2020, 5:16 PM

Closed by commit rARCdb8419f19ba2: Port "arc weld" and "arc anoid" to Toolsets workflows, plus minor fixes (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARCdb8419f19ba2: Port "arc weld" and "arc anoid" to Toolsets workflows, plus minor fixes.

Revision Contents
Changeset List

Path

Size

scripts/

breakout.py

src/

__phutil_library_map__.php

runtime/

ArcanistRuntime.php

13 lines

toolset/

ArcanistWorkflowInformation.php

10 lines

workflow/

ArcanistAliasWorkflow.php

5 lines

ArcanistShellCompleteWorkflow.php

1 line

ArcanistVersionWorkflow.php

1 line

workflow/

ArcanistAnoidWorkflow.php

42 lines

ArcanistLiberateWorkflow.php

2 lines

ArcanistWeldWorkflow.php

31 lines

ArcanistWorkflow.php

5 lines

	support/	arcanoid/
		scripts/

	arcanoid.py
	breakout.py

22 lines

Diff 50036

View Options

scripts/breakout.py

View Options

src/__phutil_library_map__.php

View Options

src/runtime/ArcanistRuntime.php

View Options

src/toolset/ArcanistWorkflowInformation.php

View Options

src/toolset/workflow/ArcanistAliasWorkflow.php

View Options

src/toolset/workflow/ArcanistShellCompleteWorkflow.php

View Options

src/toolset/workflow/ArcanistVersionWorkflow.php

View Options

src/workflow/ArcanistAnoidWorkflow.php

View Options

src/workflow/ArcanistLiberateWorkflow.php

View Options

src/workflow/ArcanistWeldWorkflow.php

View Options

src/workflow/ArcanistWorkflow.php

View Options

support/arcanoid/arcanoid.py

Port "arc weld" and "arc anoid" to Toolsets workflows, plus minor fixesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 50036

scripts/breakout.py

src/__phutil_library_map__.php

src/runtime/ArcanistRuntime.php

src/toolset/ArcanistWorkflowInformation.php

src/toolset/workflow/ArcanistAliasWorkflow.php

src/toolset/workflow/ArcanistShellCompleteWorkflow.php

src/toolset/workflow/ArcanistVersionWorkflow.php

src/workflow/ArcanistAnoidWorkflow.php

src/workflow/ArcanistLiberateWorkflow.php

src/workflow/ArcanistWeldWorkflow.php

src/workflow/ArcanistWorkflow.php

support/arcanoid/arcanoid.py

Port "arc weld" and "arc anoid" to Toolsets workflows, plus minor fixes
ClosedPublic
Actions

Revision Contents
Changeset List