Page MenuHomePhabricator
Differential D20965

Fix an issue where intracontent empty lines were incorrectly trimmed in quoted blocks
ClosedPublic
Actions

Authored by epriestley on Feb 4 2020, 4:05 PM.
Tags
None
Referenced Files
F14798709: D20965.id49957.diff
Sat, Jan 25, 6:25 AM
F14798708: D20965.id49956.diff
Sat, Jan 25, 6:25 AM
F14798707: D20965.id.diff
Sat, Jan 25, 6:25 AM
Unknown Object (File)
Sat, Jan 18, 12:57 AM
Unknown Object (File)
Sat, Jan 18, 12:19 AM
Unknown Object (File)
Wed, Jan 1, 11:14 PM
Unknown Object (File)
Sat, Dec 28, 4:33 PM
Unknown Object (File)
Dec 25 2024, 9:47 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13335: Paragraphs are collapsed incorrectly in quoted blocks in remarkup
Commits
rP84fd5cd5bb4e: Fix an issue where intracontent empty lines were incorrectly trimmed in quoted…
Summary

Fixes T13335. When processing quoted blocks, we remove leading empty lines. This logic incorrectly continued after encountering a nonempty line.

Test Plan

Added a test, made it pass. Previewed blocks in web UI.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 4 2020, 4:05 PM
Harbormaster completed remote builds in B23781: Diff 49956.Feb 4 2020, 4:07 PM
epriestley requested review of this revision.Feb 4 2020, 4:07 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 4 2020, 4:09 PM
Closed by commit rP84fd5cd5bb4e: Fix an issue where intracontent empty lines were incorrectly trimmed in quoted… (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP84fd5cd5bb4e: Fix an issue where intracontent empty lines were incorrectly trimmed in quoted….

Revision Contents
Changeset List

PathSize
src/
infrastructure/
markup/
2 lines
blockrule/
2 lines
remarkup/
__tests__/
remarkup/
11 lines

Diff 49957

View Options

src/infrastructure/markup/PhabricatorMarkupEngine.php

Loading...
View Options

src/infrastructure/markup/blockrule/PhutilRemarkupQuotedBlockRule.php

Loading...
View Options

src/infrastructure/markup/remarkup/__tests__/remarkup/quoted-paragraphs.txt

Loading...
Phabricator · Built by Phacility