Page MenuHomePhabricator

Fix an issue where intracontent empty lines were incorrectly trimmed in quoted blocks
ClosedPublic

Authored by epriestley on Feb 4 2020, 4:05 PM.
Tags
None
Referenced Files
F15399901: D20965.diff
Mon, Mar 17, 8:22 AM
F15360389: D20965.id49957.diff
Tue, Mar 11, 8:24 AM
F15356904: D20965.id49957.diff
Tue, Mar 11, 6:29 AM
Unknown Object (File)
Sat, Feb 22, 5:18 AM
Unknown Object (File)
Feb 9 2025, 8:35 AM
Unknown Object (File)
Feb 9 2025, 8:35 AM
Unknown Object (File)
Feb 9 2025, 8:35 AM
Unknown Object (File)
Jan 29 2025, 3:50 PM
Subscribers
None

Details

Summary

Fixes T13335. When processing quoted blocks, we remove leading empty lines. This logic incorrectly continued after encountering a nonempty line.

Test Plan

Added a test, made it pass. Previewed blocks in web UI.

Diff Detail

Repository
rP Phabricator
Branch
qpara1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23781
Build 32703: Run Core Tests
Build 32702: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Feb 4 2020, 4:09 PM
This revision was automatically updated to reflect the committed changes.