Differential D20965

Fix an issue where intracontent empty lines were incorrectly trimmed in quoted blocks
ClosedPublic
Actions

Authored by epriestley on Feb 4 2020, 4:05 PM.

Details

Reviewers: None
Maniphest Tasks: T13335: Paragraphs are collapsed incorrectly in quoted blocks in remarkup
Commits: rP84fd5cd5bb4e: Fix an issue where intracontent empty lines were incorrectly trimmed in quoted…

Summary

Fixes T13335. When processing quoted blocks, we remove leading empty lines. This logic incorrectly continued after encountering a nonempty line.

Test Plan

Added a test, made it pass. Previewed blocks in web UI.

Diff Detail

Repository

rP Phabricator

Branch

qpara1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23781
Build 32703: Run Core Tests
Build 32702: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 4 2020, 4:05 PM

Harbormaster completed remote builds in B23781: Diff 49956.Feb 4 2020, 4:07 PM

epriestley requested review of this revision.Feb 4 2020, 4:07 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 4 2020, 4:09 PM

Closed by commit rP84fd5cd5bb4e: Fix an issue where intracontent empty lines were incorrectly trimmed in quoted… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP84fd5cd5bb4e: Fix an issue where intracontent empty lines were incorrectly trimmed in quoted….

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

markup/

PhabricatorMarkupEngine.php

2 lines

blockrule/

PhutilRemarkupQuotedBlockRule.php

2 lines

remarkup/

__tests__/

remarkup/

quoted-paragraphs.txt

11 lines

Diff 49956

View Options

src/infrastructure/markup/PhabricatorMarkupEngine.php

View Options

src/infrastructure/markup/blockrule/PhutilRemarkupQuotedBlockRule.php

View Options

src/infrastructure/markup/remarkup/tests/remarkup/quoted-paragraphs.txt

Fix an issue where intracontent empty lines were incorrectly trimmed in quoted blocksClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 49956

src/infrastructure/markup/PhabricatorMarkupEngine.php

src/infrastructure/markup/blockrule/PhutilRemarkupQuotedBlockRule.php

src/infrastructure/markup/remarkup/__tests__/remarkup/quoted-paragraphs.txt

Fix an issue where intracontent empty lines were incorrectly trimmed in quoted blocks
ClosedPublic
Actions

Revision Contents
Changeset List

src/infrastructure/markup/remarkup/tests/remarkup/quoted-paragraphs.txt