Page MenuHomePhabricator
Differential D20965

Fix an issue where intracontent empty lines were incorrectly trimmed in quoted blocks
ClosedPublic
Actions

Authored by epriestley on Feb 4 2020, 4:05 PM.
Tags
None
Referenced Files
F19047901: D20965.id49957.diff
Thu, Nov 27, 1:42 PM
F18985322: D20965.id49956.diff
Mon, Nov 17, 12:59 PM
F18886440: D20965.id.diff
Fri, Nov 7, 4:25 AM
F18877415: D20965.diff
Thu, Nov 6, 8:15 AM
F18824778: D20965.id49957.diff
Oct 23 2025, 5:54 PM
F18818008: D20965.diff
Oct 21 2025, 8:15 PM
F18741126: D20965.id.diff
Oct 2 2025, 8:42 AM
F18734139: D20965.id.diff
Sep 30 2025, 10:48 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13335: Paragraphs are collapsed incorrectly in quoted blocks in remarkup
Commits
rP84fd5cd5bb4e: Fix an issue where intracontent empty lines were incorrectly trimmed in quoted…
Summary

Fixes T13335. When processing quoted blocks, we remove leading empty lines. This logic incorrectly continued after encountering a nonempty line.

Test Plan

Added a test, made it pass. Previewed blocks in web UI.

Diff Detail

Repository
rP Phabricator
Branch
qpara1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23781
Build 32703: Run Core Tests
Build 32702: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 4 2020, 4:05 PM
Harbormaster completed remote builds in B23781: Diff 49956.Feb 4 2020, 4:07 PM
epriestley requested review of this revision.Feb 4 2020, 4:07 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 4 2020, 4:09 PM
Closed by commit rP84fd5cd5bb4e: Fix an issue where intracontent empty lines were incorrectly trimmed in quoted… (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP84fd5cd5bb4e: Fix an issue where intracontent empty lines were incorrectly trimmed in quoted….

Revision Contents
Changeset List

PathSize
src/
infrastructure/
markup/
2 lines
blockrule/
2 lines
remarkup/
__tests__/
remarkup/
11 lines

Diff 49956

View Options

src/infrastructure/markup/PhabricatorMarkupEngine.php

Loading...
View Options

src/infrastructure/markup/blockrule/PhutilRemarkupQuotedBlockRule.php

Loading...
View Options

src/infrastructure/markup/remarkup/__tests__/remarkup/quoted-paragraphs.txt

Loading...
Phabricator · Built by Phacility