Page MenuHomePhabricator

When publishing a commit, copy "Related Tasks" from the associated revision (if one exists)
ClosedPublic

Authored by epriestley on Jan 30 2020, 6:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 20 2024, 10:03 PM
Unknown Object (File)
Feb 13 2024, 5:12 PM
Unknown Object (File)
Jan 15 2024, 9:34 PM
Unknown Object (File)
Jan 9 2024, 8:20 AM
Unknown Object (File)
Dec 26 2023, 6:48 AM
Unknown Object (File)
Dec 20 2023, 12:31 PM
Unknown Object (File)
Dec 19 2023, 2:30 AM
Unknown Object (File)
Nov 30 2023, 12:20 AM
Subscribers
None

Details

Summary

Fixes T13463. Currently, if you use the web UI to set "Related Tasks" for a revision, the resulting commit does not link to the tasks.

If you use "Ref ..." in the message instead, the resulting commit does link to the tasks.

Broadly, this should all be cleaner (see T3577) but we can step toward better behavior by just copying these edges when commits are published.

Test Plan
  • Created a revision.
  • Used the web UI to edit "Related Tasks".
  • Landed the revision.
  • Saw the commit link to the tasks as though I'd used "Ref ..." in the message.

Diff Detail

Repository
rP Phabricator
Branch
ref1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23763
Build 32680: Run Core Tests
Build 32679: arc lint + arc unit