Differential D20961

When publishing a commit, copy "Related Tasks" from the associated revision (if one exists)
ClosedPublic
Actions

Authored by epriestley on Jan 30 2020, 6:32 PM.

Details

Reviewers: None
Maniphest Tasks: T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx"
Commits: rP4904d7711ea1: When publishing a commit, copy "Related Tasks" from the associated revision (if…

Summary

Fixes T13463. Currently, if you use the web UI to set "Related Tasks" for a revision, the resulting commit does not link to the tasks.

If you use "Ref ..." in the message instead, the resulting commit does link to the tasks.

Broadly, this should all be cleaner (see T3577) but we can step toward better behavior by just copying these edges when commits are published.

Test Plan

Created a revision.
Used the web UI to edit "Related Tasks".
Landed the revision.
Saw the commit link to the tasks as though I'd used "Ref ..." in the message.

Diff Detail

Repository

rP Phabricator

Branch

ref1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23763
Build 32680: Run Core Tests
Build 32679: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 30 2020, 6:32 PM

Harbormaster completed remote builds in B23763: Diff 49937.Jan 30 2020, 6:33 PM

epriestley requested review of this revision.Jan 30 2020, 6:33 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 4 2020, 3:05 PM

Closed by commit rP4904d7711ea1: When publishing a commit, copy "Related Tasks" from the associated revision (if… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP4904d7711ea1: When publishing a commit, copy "Related Tasks" from the associated revision (if….

Revision Contents
Changeset List

Path

Size

src/

applications/

audit/

editor/

PhabricatorAuditEditor.php

25 lines

Diff 49937

View Options

src/applications/audit/editor/PhabricatorAuditEditor.php

When publishing a commit, copy "Related Tasks" from the associated revision (if one exists)ClosedPublicActions