Page MenuHomePhabricator
Differential D20961

When publishing a commit, copy "Related Tasks" from the associated revision (if one exists)
ClosedPublic
Actions

Authored by epriestley on Jan 30 2020, 6:32 PM.
Tags
None
Referenced Files
F14316025: D20961.diff
Wed, Dec 18, 6:46 AM
Unknown Object (File)
Tue, Dec 17, 1:41 AM
Unknown Object (File)
Wed, Dec 11, 4:19 PM
Unknown Object (File)
Sat, Dec 7, 11:38 PM
Unknown Object (File)
Sat, Dec 7, 1:43 AM
Unknown Object (File)
Thu, Dec 5, 7:48 PM
Unknown Object (File)
Thu, Dec 5, 7:59 AM
Unknown Object (File)
Tue, Dec 3, 4:14 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx"
Commits
rP4904d7711ea1: When publishing a commit, copy "Related Tasks" from the associated revision (if…
Summary

Fixes T13463. Currently, if you use the web UI to set "Related Tasks" for a revision, the resulting commit does not link to the tasks.

If you use "Ref ..." in the message instead, the resulting commit does link to the tasks.

Broadly, this should all be cleaner (see T3577) but we can step toward better behavior by just copying these edges when commits are published.

Test Plan
  • Created a revision.
  • Used the web UI to edit "Related Tasks".
  • Landed the revision.
  • Saw the commit link to the tasks as though I'd used "Ref ..." in the message.

Diff Detail

Repository
rP Phabricator
Branch
ref1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23763
Build 32680: Run Core Tests
Build 32679: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
audit/
editor/
25 lines

Diff 49937

View Options

src/applications/audit/editor/PhabricatorAuditEditor.php

Loading...
Phabricator · Built by Phacility