Differential D20952

Omit "--" in older fallback commands for Git remote URIs
ClosedPublic
Actions

Authored by epriestley on Jan 24 2020, 12:39 AM.

Details

Reviewers: None
Maniphest Tasks: T13481: Don't require "git remote get-url" in Arcanist
Commits: rARC729100955129: (stable) Promote 2020 Week 5
rARC21a1828ea06c: Omit "--" in older fallback commands for Git remote URIs

Summary

Ref T13481. Some older versions of Git appear to not support "--" in these commands. Just drop it. This can lead to ambiguous results with certain obviously-silly remote names, but doesn't appear to lead to anything dangerous.

Test Plan

Will followup with user on ancient Git.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 24 2020, 12:39 AM

Harbormaster completed remote builds in B23742: Diff 49916.Jan 24 2020, 12:39 AM

epriestley requested review of this revision.Jan 24 2020, 12:39 AM

Only omit "--" in "git ls-remote", since it seems like it's okay for even very old "git config".

It's possible that "--" doesn't work in VERY VERY OLD "git config", but we can always drop it if a user with Rare Beta Git shows up.

Harbormaster completed remote builds in B23743: Diff 49917.Jan 24 2020, 12:50 AM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 24 2020, 12:50 AM

Closed by commit rARC21a1828ea06c: Omit "--" in older fallback commands for Git remote URIs (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC21a1828ea06c: Omit "--" in older fallback commands for Git remote URIs.

epriestley added a commit: rARC729100955129: (stable) Promote 2020 Week 5.Jan 30 2020, 9:21 PM

Revision Contents
Changeset List

Path

Size

src/

repository/

api/

ArcanistGitAPI.php

10 lines

Diff 49918

View Options

src/repository/api/ArcanistGitAPI.php

Omit "--" in older fallback commands for Git remote URIsClosedPublicActions