Page MenuHomePhabricator

Omit "--" in older fallback commands for Git remote URIs
ClosedPublic

Authored by epriestley on Jan 24 2020, 12:39 AM.
Tags
None
Referenced Files
F14492585: D20952.id49918.diff
Thu, Jan 2, 8:40 PM
Unknown Object (File)
Fri, Dec 27, 5:53 PM
Unknown Object (File)
Sun, Dec 15, 6:01 PM
Unknown Object (File)
Thu, Dec 12, 8:22 PM
Unknown Object (File)
Mon, Dec 9, 6:55 PM
Unknown Object (File)
Dec 3 2024, 11:24 AM
Unknown Object (File)
Nov 23 2024, 3:21 AM
Unknown Object (File)
Oct 19 2024, 5:40 AM
Subscribers
None

Details

Summary

Ref T13481. Some older versions of Git appear to not support "--" in these commands. Just drop it. This can lead to ambiguous results with certain obviously-silly remote names, but doesn't appear to lead to anything dangerous.

Test Plan

Will followup with user on ancient Git.

Diff Detail

Repository
rARC Arcanist
Branch
land1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23743
Build 32652: Run Core Tests
Build 32651: arc lint + arc unit

Event Timeline

  • Only omit "--" in "git ls-remote", since it seems like it's okay for even very old "git config".

It's possible that "--" doesn't work in VERY VERY OLD "git config", but we can always drop it if a user with Rare Beta Git shows up.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 24 2020, 12:50 AM
This revision was automatically updated to reflect the committed changes.