Differential D20943

Allow the Herald Rule Editor to apply generic "Edge" transactions
ClosedPublic
Actions

Authored by epriestley on Jan 15 2020, 4:27 PM.

Tags

None

Referenced Files

	F15407758: D20943.diff
	Tue, Mar 18, 7:23 PM

	F15398200: D20943.id49902.diff
	Sun, Mar 16, 11:46 PM

	F15387111: D20943.id49901.diff
	Sat, Mar 15, 1:51 AM

	F15345107: D20943.diff
	Mon, Mar 10, 8:32 AM

	Unknown Object (File)
	Feb 17 2025, 1:55 AM

	Unknown Object (File)
	Feb 16 2025, 7:03 PM

	Unknown Object (File)
	Feb 9 2025, 8:31 AM

	Unknown Object (File)
	Feb 9 2025, 8:31 AM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13469: Muting Herald notifications fail with `Unhandled Exception ("PhabricatorApplicationTransactionStructureException")`
Commits: rPf806528983b6: Allow the Herald Rule Editor to apply generic "Edge" transactions

Summary

Fixes T13469. Currently, "Mute" applies a generic edge transaction but the editor doesn't whitelist them.

Test Plan

Muted a Herald rule.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 15 2020, 4:27 PM

Harbormaster completed remote builds in B23727: Diff 49901.Jan 15 2020, 4:29 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 15 2020, 4:29 PM

epriestley requested review of this revision.

Closed by commit rPf806528983b6: Allow the Herald Rule Editor to apply generic "Edge" transactions (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPf806528983b6: Allow the Herald Rule Editor to apply generic "Edge" transactions.

epriestley mentioned this in T13469: Muting Herald notifications fail with `Unhandled Exception ("PhabricatorApplicationTransactionStructureException")`.Jan 15 2020, 4:31 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

herald/

editor/

HeraldRuleEditor.php

6 lines

Diff 49902

src/applications/herald/editor/HeraldRuleEditor.php

Loading...