Differential D20943

Allow the Herald Rule Editor to apply generic "Edge" transactions
ClosedPublic
Actions

Authored by epriestley on Jan 15 2020, 4:27 PM.

Tags

None

Referenced Files

	F18248397: D20943.id.diff
	Thu, Aug 21, 1:12 PM

	F18226154: D20943.diff
	Wed, Aug 20, 3:29 AM

	F18100829: D20943.diff
	Sat, Aug 9, 12:07 PM

	F17847673: D20943.id49902.diff
	Sun, Jul 27, 6:24 AM

	F17823151: D20943.diff
	Sat, Jul 26, 4:22 AM

	F17692696: D20943.diff
	Jul 15 2025, 4:07 AM

	Unknown Object (File)
	Jun 16 2025, 8:30 PM

	Unknown Object (File)
	Jun 16 2025, 11:30 AM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13469: Muting Herald notifications fail with `Unhandled Exception ("PhabricatorApplicationTransactionStructureException")`
Commits: rPf806528983b6: Allow the Herald Rule Editor to apply generic "Edge" transactions

Summary

Fixes T13469. Currently, "Mute" applies a generic edge transaction but the editor doesn't whitelist them.

Test Plan

Muted a Herald rule.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 15 2020, 4:27 PM

Harbormaster completed remote builds in B23727: Diff 49901.Jan 15 2020, 4:29 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 15 2020, 4:29 PM

epriestley requested review of this revision.

Closed by commit rPf806528983b6: Allow the Herald Rule Editor to apply generic "Edge" transactions (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPf806528983b6: Allow the Herald Rule Editor to apply generic "Edge" transactions.

epriestley mentioned this in T13469: Muting Herald notifications fail with `Unhandled Exception ("PhabricatorApplicationTransactionStructureException")`.Jan 15 2020, 4:31 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

herald/

editor/

HeraldRuleEditor.php

6 lines

Diff 49902

src/applications/herald/editor/HeraldRuleEditor.php

Loading...