Update deprecated array access syntax in Porter stemmer
ClosedPublic
Actions

Authored by epriestley on Jan 14 2020, 8:04 PM.

Details

Reviewers: None
Maniphest Tasks: T13472: Porter stemmer library uses obsolete array access syntax which raises warning under PHP 7.4
Commits: rPdb6b4ca480ad: Update deprecated array access syntax in Porter stemmer

Summary

Fixes T13472. This library uses $a{0}, but this is deprecated in favor of $a[0].

Test Plan

Ran bin/search index Txxx --force on a task with "filing" in the title (this term reaches the "m" rule of the stemmer).

(I'm not on new enough PHP for this to actually raise an error, but I'll follow up with the reporting user.)

Diff Detail

Repository

rP Phabricator

Branch

stem3

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 23723
Build 32620: Run Core Tests
Build 32619: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 14 2020, 8:04 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 14 2020, 8:06 PM

Harbormaster failed remote builds in B23722: Diff 49896!

Fix accidental index change which caused a stemming test failure.

Harbormaster completed remote builds in B23723: Diff 49897.Jan 14 2020, 8:11 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 14 2020, 8:11 PM

epriestley requested review of this revision.

Closed by commit rPdb6b4ca480ad: Update deprecated array access syntax in Porter stemmer (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPdb6b4ca480ad: Update deprecated array access syntax in Porter stemmer.

Revision Contents
Changeset List

Path

Size

externals/

porter-stemmer/

src/

Porter.php

8 lines

Diff 49897

View Options

externals/porter-stemmer/src/Porter.php

Update deprecated array access syntax in Porter stemmerClosedPublicActions