Page MenuHomePhabricator

Update deprecated array access syntax in Porter stemmer
ClosedPublic

Authored by epriestley on Jan 14 2020, 8:04 PM.

Details

Summary

Fixes T13472. This library uses $a{0}, but this is deprecated in favor of $a[0].

Test Plan

Ran bin/search index Txxx --force on a task with "filing" in the title (this term reaches the "m" rule of the stemmer).

(I'm not on new enough PHP for this to actually raise an error, but I'll follow up with the reporting user.)

Diff Detail

Repository
rP Phabricator
Branch
stem3
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 23722
Build 32618: Run Core Tests
Build 32617: arc lint + arc unit

Unit TestsFailed

TimeTest
2 msPhutilSearchStemmerTestCase::testStemTokens
Assertion failed, expected values to be equal (at PhutilSearchStemmerTestCase.php:54): Token stem of "implementing". Expected: 'implement' Actual: 'implemen'
1 msAlmanacNamesTestCase::testServiceOrDeviceNames
30 assertions passed.
0 msAlmanacServiceTypeTestCase::testGetAllServiceTypes
1 assertion passed.
0 msAphrontHTTPSinkTestCase::testHTTPHeaderNames
2 assertions passed.
0 msAphrontHTTPSinkTestCase::testHTTPSinkBasics
3 assertions passed.
View Full Test Results (1 Failed · 390 Passed)

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 14 2020, 8:06 PM
Harbormaster failed remote builds in B23722: Diff 49896!
  • Fix accidental index change which caused a stemming test failure.
This revision was not accepted when it landed; it landed in state Needs Review.Jan 14 2020, 8:11 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.