Differential D20906

Surface edits to "Text" panels on dashboards as remarkup edits
ClosedPublic
Actions

Authored by epriestley on Nov 13 2019, 6:32 PM.

Details

Reviewers: None
Maniphest Tasks: T13456: Surface changes to the text in "Text" dashboard panels as a Remarkup edit (so files link, etc)
Commits: rPe86aae99de0b: Surface edits to "Text" panels on dashboards as remarkup edits

Summary

Fixes T13456. These edits are remarkup edits and should attach files, trigger mentions, and so on.

Test Plan

Created a text panel, dropped a file in. After changes, saw the file attach properly.

Diff Detail

Repository

rP Phabricator

Branch

textpanel1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23655
Build 32519: Run Core Tests
Build 32518: arc lint + arc unit

Event Timeline

epriestley created this revision.Nov 13 2019, 6:32 PM

Harbormaster completed remote builds in B23655: Diff 49827.Nov 13 2019, 6:33 PM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 13 2019, 6:33 PM

epriestley requested review of this revision.

Closed by commit rPe86aae99de0b: Surface edits to "Text" panels on dashboards as remarkup edits (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPe86aae99de0b: Surface edits to "Text" panels on dashboards as remarkup edits.

Revision Contents
Changeset List

Path

Size

src/

applications/

dashboard/

xaction/

panel/

PhabricatorDashboardTextPanelTextTransaction.php

10 lines

Diff 49827

View Options

src/applications/dashboard/xaction/panel/PhabricatorDashboardTextPanelTextTransaction.php

Surface edits to "Text" panels on dashboards as remarkup editsClosedPublicActions