Page MenuHomePhabricator
Differential D20906

Surface edits to "Text" panels on dashboards as remarkup edits
ClosedPublic
Actions

Authored by epriestley on Nov 13 2019, 6:32 PM.
Tags
None
Referenced Files
F13063209: D20906.diff
Sat, Apr 20, 5:52 AM
Unknown Object (File)
Thu, Apr 11, 10:09 AM
Unknown Object (File)
Wed, Apr 10, 9:47 PM
Unknown Object (File)
Sun, Mar 31, 8:08 PM
Unknown Object (File)
Sat, Mar 30, 2:17 PM
Unknown Object (File)
Mar 6 2024, 1:51 AM
Unknown Object (File)
Feb 17 2024, 4:46 PM
Unknown Object (File)
Feb 13 2024, 5:12 PM
View All 79 Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13456: Surface changes to the text in "Text" dashboard panels as a Remarkup edit (so files link, etc)
Commits
rPe86aae99de0b: Surface edits to "Text" panels on dashboards as remarkup edits
Summary

Fixes T13456. These edits are remarkup edits and should attach files, trigger mentions, and so on.

Test Plan

Created a text panel, dropped a file in. After changes, saw the file attach properly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Nov 13 2019, 6:32 PM
Harbormaster completed remote builds in B23655: Diff 49827.Nov 13 2019, 6:33 PM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 13 2019, 6:33 PM
epriestley requested review of this revision.
Closed by commit rPe86aae99de0b: Surface edits to "Text" panels on dashboards as remarkup edits (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPe86aae99de0b: Surface edits to "Text" panels on dashboards as remarkup edits.

Revision Contents
Changeset List

PathSize
src/
applications/
dashboard/
xaction/
panel/
10 lines

Diff 49828

View Options

src/applications/dashboard/xaction/panel/PhabricatorDashboardTextPanelTextTransaction.php

Loading...
Phabricator · Built by Phacility