Page MenuHomePhabricator

Show repository information (and use repository identities) in commit hovercards
ClosedPublic

Authored by epriestley on Oct 31 2019, 3:58 PM.
Tags
None
Referenced Files
F15470170: D20881.diff
Fri, Apr 4, 8:57 PM
F15462580: D20881.id49779.diff
Tue, Apr 1, 4:08 PM
F15455178: D20881.diff
Sat, Mar 29, 10:39 PM
F15447964: D20881.id49780.diff
Fri, Mar 28, 2:34 AM
F15438050: D20881.id.diff
Tue, Mar 25, 11:01 PM
F15433676: D20881.id49779.diff
Tue, Mar 25, 12:16 AM
F15431888: D20881.id.diff
Mon, Mar 24, 3:12 PM
F15429741: D20881.diff
Mon, Mar 24, 4:03 AM
Subscribers
None

Details

Summary

Ref T12164. Ref T13439. Commit hovercards don't currently show the repository. Although this is sometimes obvious from context, it isn't at other times and it's clearly useful/important.

Also, use identities to render author/committer information and show committer if the committer differs from the author.

Test Plan

Screen Shot 2019-10-31 at 8.55.47 AM.png (220×452 px, 27 KB)

Diff Detail

Repository
rP Phabricator
Branch
hover1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23608
Build 32450: Run Core Tests
Build 32449: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Oct 31 2019, 4:58 PM
This revision was automatically updated to reflect the committed changes.