Differential D20881

Show repository information (and use repository identities) in commit hovercards
ClosedPublic
Actions

Authored by epriestley on Oct 31 2019, 3:58 PM.

Details

Reviewers: None
Maniphest Tasks: T12164: Put an indirection layer between author/committer strings and user accounts
T13439: Include repository information on commit hovercards
Commits: rP97bed3508579: Show repository information (and use repository identities) in commit hovercards

Summary

Ref T12164. Ref T13439. Commit hovercards don't currently show the repository. Although this is sometimes obvious from context, it isn't at other times and it's clearly useful/important.

Also, use identities to render author/committer information and show committer if the committer differs from the author.

Test Plan

Screen Shot 2019-10-31 at 8.55.47 AM.png (220×452 px, 27 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Oct 31 2019, 3:58 PM

Harbormaster completed remote builds in B23608: Diff 49779.Oct 31 2019, 4:00 PM

epriestley requested review of this revision.Oct 31 2019, 4:00 PM

This revision was not accepted when it landed; it landed in state Needs Review.Oct 31 2019, 4:58 PM

Closed by commit rP97bed3508579: Show repository information (and use repository identities) in commit hovercards (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP97bed3508579: Show repository information (and use repository identities) in commit hovercards.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

engineextension/

DiffusionHovercardEngineExtension.php

43 lines

Diff 49780

View Options

src/applications/diffusion/engineextension/DiffusionHovercardEngineExtension.php

Show repository information (and use repository identities) in commit hovercardsClosedPublicActions