Page MenuHomePhabricator
Differential D20825

Add an "{anchor #xyz}" rule to Remarkup
ClosedPublic
Actions

Authored by epriestley on Sep 24 2019, 5:26 PM.
Tags
None
Referenced Files
F15450164: D20825.id.diff
Fri, Mar 28, 2:20 PM
F15427151: D20825.id49649.diff
Sun, Mar 23, 1:08 PM
F15426468: D20825.id49655.diff
Sun, Mar 23, 8:56 AM
F15424527: D20825.id.diff
Sat, Mar 22, 10:54 PM
F15420885: D20825.diff
Fri, Mar 21, 6:39 PM
F15419600: D20825.diff
Fri, Mar 21, 7:16 AM
F15417512: D20825.id.diff
Thu, Mar 20, 5:22 PM
F15415375: D20825.diff
Thu, Mar 20, 5:40 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T4280: Embed anchor in remark up text and later link to it.
T13410: Update Phriction UI structural behaviors
Commits
rPb1d4d5c00ce1: Add an "{anchor #xyz}" rule to Remarkup
Summary

Ref T13410. Fixes T4280. Allows you to put a named anchor into a document explicitly.

Test Plan

Used {anchor ...} in Remarkup, used location bar to jump to anchors.

Diff Detail

Repository
rP Phabricator
Branch
anchor3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23476
Build 32260: Run Core Tests
Build 32259: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 24 2019, 5:26 PM
Harbormaster completed remote builds in B23476: Diff 49649.Sep 24 2019, 5:27 PM
epriestley requested review of this revision.Sep 24 2019, 5:27 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 24 2019, 6:04 PM
Closed by commit rPb1d4d5c00ce1: Add an "{anchor #xyz}" rule to Remarkup (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPb1d4d5c00ce1: Add an "{anchor #xyz}" rule to Remarkup.

Revision Contents
Changeset List

PathSize
src/
docs/
user/
userguide/
12 lines
infrastructure/
markup/
1 line
blockrule/
7 lines
markuprule/
69 lines

Diff 49649

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/docs/user/userguide/remarkup.diviner

Loading...
View Options

src/infrastructure/markup/PhabricatorMarkupEngine.php

Loading...
View Options

src/infrastructure/markup/blockrule/PhutilRemarkupHeaderBlockRule.php

Loading...
View Options

src/infrastructure/markup/markuprule/PhutilRemarkupAnchorRule.php

Loading...
Phabricator · Built by Phacility