Page MenuHomePhabricator
Differential D20822

Unprototype "Facts" to clear Maniphest/chart fatals
ClosedPublic
Actions

Authored by epriestley on Sep 23 2019, 7:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Feb 11, 4:13 PM
Unknown Object (File)
Sun, Feb 9, 8:10 AM
Unknown Object (File)
Sun, Feb 9, 8:10 AM
Unknown Object (File)
Sun, Feb 9, 8:10 AM
Unknown Object (File)
Sun, Feb 2, 2:05 AM
Unknown Object (File)
Tue, Jan 28, 5:22 AM
Unknown Object (File)
Tue, Jan 28, 5:22 AM
Unknown Object (File)
Tue, Jan 28, 5:22 AM
View All Files
Subscribers
yelirekim

Details

Reviewers
None
Maniphest Tasks
T13279: Build Charting for Facts
Commits
rP09d86c2d2031: Unprototype "Facts" to clear Maniphest/chart fatals
Summary

Ref T13279. Facts is still fairly rough, but not broken/policy-violating, so it can be unprototyped to fix the issue where Maniphest reports (which are now driven by Facts) don't work if prototypes are disabled.

Test Plan

Viewed Maniphest reports and Project reports with prototypes on/off and Fact installed/uninstalled.

Diff Detail

Repository
rP Phabricator
Branch
fact1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23467
Build 32246: Run Core Tests
Build 32245: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 23 2019, 7:43 PM
Herald added a subscriber: yelirekim. · View Herald TranscriptSep 23 2019, 7:43 PM
Harbormaster completed remote builds in B23467: Diff 49641.Sep 23 2019, 7:44 PM
epriestley requested review of this revision.Sep 23 2019, 7:44 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 23 2019, 8:01 PM
Closed by commit rP09d86c2d2031: Unprototype "Facts" to clear Maniphest/chart fatals (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP09d86c2d2031: Unprototype "Facts" to clear Maniphest/chart fatals.

Revision Contents
Changeset List

PathSize
src/
applications/
fact/
application/
5 lines
controller/
41 lines
53 lines
engine/
2 lines
maniphest/
controller/
8 lines
project/
menuitem/
5 lines

Diff 49641

View Options

src/applications/fact/application/PhabricatorFactApplication.php

Loading...
View Options

src/applications/fact/controller/PhabricatorFactChartController.php

Loading...
View Options

src/applications/fact/controller/PhabricatorFactHomeController.php

Loading...
View Options

src/applications/fact/engine/PhabricatorDemoChartEngine.php

Loading...
View Options

src/applications/maniphest/controller/ManiphestReportController.php

Loading...
View Options

src/applications/project/menuitem/PhabricatorProjectReportsProfileMenuItem.php

Loading...
Phabricator · Built by Phacility