Page MenuHomePhabricator

Unprototype "Facts" to clear Maniphest/chart fatals
ClosedPublic

Authored by epriestley on Sep 23 2019, 7:43 PM.
Tags
None
Referenced Files
F15426190: D20822.id49642.diff
Sun, Mar 23, 7:38 AM
F15420968: D20822.id49641.diff
Fri, Mar 21, 7:39 PM
F15415922: D20822.id.diff
Thu, Mar 20, 8:28 AM
F15409877: D20822.diff
Wed, Mar 19, 5:44 AM
F15401153: D20822.id49642.diff
Mon, Mar 17, 4:00 PM
Unknown Object (File)
Tue, Feb 25, 3:32 PM
Unknown Object (File)
Sun, Feb 23, 11:37 PM
Unknown Object (File)
Sun, Feb 23, 11:36 PM
Subscribers

Details

Summary

Ref T13279. Facts is still fairly rough, but not broken/policy-violating, so it can be unprototyped to fix the issue where Maniphest reports (which are now driven by Facts) don't work if prototypes are disabled.

Test Plan

Viewed Maniphest reports and Project reports with prototypes on/off and Fact installed/uninstalled.

Diff Detail

Repository
rP Phabricator
Branch
fact1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23467
Build 32246: Run Core Tests
Build 32245: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 23 2019, 8:01 PM
This revision was automatically updated to reflect the committed changes.