Page MenuHomePhabricator

Add a "Remove flag" action to Herald
ClosedPublic

Authored by epriestley on Sep 9 2019, 8:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 2:03 AM
Unknown Object (File)
Wed, Apr 24, 4:21 PM
Unknown Object (File)
Sun, Mar 31, 2:00 AM
Unknown Object (File)
Mar 14 2024, 9:40 AM
Unknown Object (File)
Mar 13 2024, 4:26 AM
Unknown Object (File)
Feb 13 2024, 1:14 PM
Unknown Object (File)
Jan 10 2024, 8:07 AM
Unknown Object (File)
Jan 1 2024, 8:20 PM
Subscribers
None

Details

Summary

Fixes T13409. This is a companion to the existing "Mark with flag" rule.

Test Plan

Used a "remove flag" rule on an object with no flag (not removed), the right type of flag (removed), and a different type of flag (not removed).

Diff Detail

Repository
rP Phabricator
Branch
flag1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23412
Build 32163: Run Core Tests
Build 32162: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 9 2019, 8:16 PM
This revision was automatically updated to reflect the committed changes.