Page MenuHomePhabricator

Add a "Remove flag" action to Herald
ClosedPublic

Authored by epriestley on Sep 9 2019, 8:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Aug 31 2026, 1:01 AM
Unknown Object (File)
Aug 13 2026, 5:44 PM
Unknown Object (File)
Jul 3 2026, 5:27 AM
Unknown Object (File)
Jul 3 2026, 5:26 AM
Unknown Object (File)
Jul 3 2026, 5:26 AM
Unknown Object (File)
Jun 24 2026, 4:50 AM
Unknown Object (File)
Jun 22 2026, 10:00 AM
Unknown Object (File)
Jun 21 2026, 8:23 PM
Subscribers
None

Details

Summary

Fixes T13409. This is a companion to the existing "Mark with flag" rule.

Test Plan

Used a "remove flag" rule on an object with no flag (not removed), the right type of flag (removed), and a different type of flag (not removed).

Diff Detail

Repository
rP Phabricator
Branch
flag1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23412
Build 32163: Run Core Tests
Build 32162: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 9 2019, 8:16 PM
This revision was automatically updated to reflect the committed changes.