Page MenuHomePhabricator

Add a "Remove flag" action to Herald
ClosedPublic

Authored by epriestley on Sep 9 2019, 8:02 PM.
Tags
None
Referenced Files
F18100692: D20796.id.diff
Sat, Aug 9, 12:00 PM
F18091614: D20796.id49589.diff
Wed, Aug 6, 11:53 PM
F18090503: D20796.id49587.diff
Wed, Aug 6, 4:05 PM
F18083463: D20796.id.diff
Tue, Aug 5, 10:20 AM
F18073233: D20796.diff
Mon, Aug 4, 5:15 PM
F17712039: D20796.diff
Jul 17 2025, 9:22 AM
Unknown Object (File)
Jul 4 2025, 2:56 PM
Unknown Object (File)
Jul 3 2025, 10:33 PM
Subscribers
None

Details

Summary

Fixes T13409. This is a companion to the existing "Mark with flag" rule.

Test Plan

Used a "remove flag" rule on an object with no flag (not removed), the right type of flag (removed), and a different type of flag (not removed).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 9 2019, 8:16 PM
This revision was automatically updated to reflect the committed changes.