Page MenuHomePhabricator

Add a "Remove flag" action to Herald
ClosedPublic

Authored by epriestley on Sep 9 2019, 8:02 PM.
Tags
None
Referenced Files
F15335133: D20796.id49589.diff
Sat, Mar 8, 2:26 PM
F15333209: D20796.id49587.diff
Sat, Mar 8, 12:51 AM
F15333139: D20796.id.diff
Sat, Mar 8, 12:15 AM
Unknown Object (File)
Thu, Feb 20, 2:19 AM
Unknown Object (File)
Feb 17 2025, 2:50 AM
Unknown Object (File)
Feb 10 2025, 8:15 PM
Unknown Object (File)
Feb 9 2025, 8:06 AM
Unknown Object (File)
Feb 9 2025, 8:06 AM
Subscribers
None

Details

Summary

Fixes T13409. This is a companion to the existing "Mark with flag" rule.

Test Plan

Used a "remove flag" rule on an object with no flag (not removed), the right type of flag (removed), and a different type of flag (not removed).

Diff Detail

Repository
rP Phabricator
Branch
flag1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23412
Build 32163: Run Core Tests
Build 32162: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 9 2019, 8:16 PM
This revision was automatically updated to reflect the committed changes.