Page MenuHomePhabricator

Add a "Remove flag" action to Herald
ClosedPublic

Authored by epriestley on Sep 9 2019, 8:02 PM.
Tags
None
Referenced Files
F19080558: D20796.diff
Tue, Dec 2, 1:42 AM
F19080543: D20796.diff
Tue, Dec 2, 1:40 AM
F18906281: D20796.diff
Sat, Nov 8, 5:45 PM
F18841327: D20796.diff
Oct 28 2025, 8:13 AM
F18836837: D20796.id49587.diff
Oct 27 2025, 3:43 AM
F18833576: D20796.diff
Oct 26 2025, 4:33 AM
F18798853: D20796.id.diff
Oct 17 2025, 9:21 AM
F18791699: D20796.diff
Oct 16 2025, 4:59 PM
Subscribers
None

Details

Summary

Fixes T13409. This is a companion to the existing "Mark with flag" rule.

Test Plan

Used a "remove flag" rule on an object with no flag (not removed), the right type of flag (removed), and a different type of flag (not removed).

Diff Detail

Repository
rP Phabricator
Branch
flag1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23412
Build 32163: Run Core Tests
Build 32162: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 9 2019, 8:16 PM
This revision was automatically updated to reflect the committed changes.