Differential D20792

Fix global search scope fatal on 404 page (or other pages with no Application)
ClosedPublic
Actions

Authored by epriestley on Sep 9 2019, 7:11 PM.

Tags

None

Referenced Files

	F15427878: D20792.diff
	Sun, Mar 23, 4:39 PM

	F15378840: D20792.id.diff
	Thu, Mar 13, 5:19 PM

	Unknown Object (File)
	Feb 12 2025, 2:26 AM

	Unknown Object (File)
	Feb 9 2025, 8:06 AM

	Unknown Object (File)
	Feb 9 2025, 8:06 AM

	Unknown Object (File)
	Feb 9 2025, 8:06 AM

	Unknown Object (File)
	Feb 9 2025, 8:06 AM

	Unknown Object (File)
	Jan 25 2025, 5:42 AM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13405: Support customization of the default global search scope
Commits: rP984e253d41e7: (stable) Fix global search scope fatal on 404 page (or other pages with no…
rP63c7302af130: Fix global search scope fatal on 404 page (or other pages with no Application)

Summary

Ref T13405. Some pages don't have a contextual application.

Test Plan

Viewed 404 page, no more fatal.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Sep 9 2019, 7:11 PM

Harbormaster completed remote builds in B23401: Diff 49576.Sep 9 2019, 7:12 PM

epriestley requested review of this revision.Sep 9 2019, 7:12 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 9 2019, 7:18 PM

Closed by commit rP63c7302af130: Fix global search scope fatal on 404 page (or other pages with no Application) (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP63c7302af130: Fix global search scope fatal on 404 page (or other pages with no Application).

epriestley added a commit: rP984e253d41e7: (stable) Fix global search scope fatal on 404 page (or other pages with no….Sep 10 2019, 2:11 PM

Revision Contents
Changeset List

Path

Size

src/

view/

page/

menu/

PhabricatorMainMenuSearchView.php

2 lines

Diff 49580

src/view/page/menu/PhabricatorMainMenuSearchView.php

Loading...