Fix a warning in BoardLayoutEngine when no objects are being updated
ClosedPublic
Actions

Authored by epriestley on Aug 7 2019, 4:20 PM.

Details

Reviewers: None
Maniphest Tasks: T13368: Correct several issues with "Move to Project..." on Workboards
Commits: rP937edcdc580c: Fix a warning in BoardLayoutEngine when no objects are being updated

Summary

Fixes T13368. Some workflows (like "Move tasks to...") execute board layout without objects to update. In these cases, we can hit a warning because objectPHIDs is not initialized to array().

Test Plan

Went through the "Move tasks to..." workflow on a workboard, no longer saw a warning when trying to iterate over an empty objectPHIDs list.

Diff Detail

Repository

rP Phabricator

Branch

column4

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23230
Build 31912: Run Core Tests
Build 31911: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 7 2019, 4:20 PM

epriestley edited the summary of this revision. (Show Details)Aug 7 2019, 4:20 PM

Harbormaster completed remote builds in B23230: Diff 49365.Aug 7 2019, 4:21 PM

epriestley requested review of this revision.Aug 7 2019, 4:21 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 8 2019, 5:18 PM

Closed by commit rP937edcdc580c: Fix a warning in BoardLayoutEngine when no objects are being updated (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP937edcdc580c: Fix a warning in BoardLayoutEngine when no objects are being updated.

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

engine/

PhabricatorBoardLayoutEngine.php

2 lines

Diff 49365

View Options

src/applications/project/engine/PhabricatorBoardLayoutEngine.php

Fix a warning in BoardLayoutEngine when no objects are being updatedClosedPublicActions