Page MenuHomePhabricator

Fix a warning in BoardLayoutEngine when no objects are being updated
ClosedPublic

Authored by epriestley on Aug 7 2019, 4:20 PM.

Details

Summary

Fixes T13368. Some workflows (like "Move tasks to...") execute board layout without objects to update. In these cases, we can hit a warning because objectPHIDs is not initialized to array().

Test Plan

Went through the "Move tasks to..." workflow on a workboard, no longer saw a warning when trying to iterate over an empty objectPHIDs list.

Diff Detail

Repository
rP Phabricator
Branch
column4
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 23230
Build 31912: Run Core Tests
Build 31911: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 7 2019, 4:20 PM
epriestley edited the summary of this revision. (Show Details)Aug 7 2019, 4:20 PM
epriestley requested review of this revision.Aug 7 2019, 4:21 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 8 2019, 5:18 PM
This revision was automatically updated to reflect the committed changes.