Page MenuHomePhabricator

Fix an issue where lines with more than one pattern match highlighted improperly in Diffusion
ClosedPublic

Authored by epriestley on Aug 2 2019, 4:42 PM.
Tags
None
Referenced Files
F21693243: D20695.diff
Fri, Aug 7, 12:26 PM
F21691066: D20695.id49358.diff
Fri, Aug 7, 9:33 AM
F21691064: D20695.id49357.diff
Fri, Aug 7, 9:33 AM
Unknown Object (File)
Tue, Aug 4, 3:33 AM
Unknown Object (File)
Mon, Aug 3, 2:53 PM
Unknown Object (File)
Jul 2 2026, 2:50 PM
Unknown Object (File)
Jun 27 2026, 11:24 PM
Unknown Object (File)
Jun 25 2026, 2:40 PM
Subscribers
None

Details

Summary

Ref T13339. If a search pattern matches more than once on a line, we currently render the line incorreclty, duplicating some of the text.

substr() is being called as though the third parameter was end_offset, but it's actually length. Correct the parameter.

Test Plan

Before:

Screen Shot 2019-08-02 at 9.40.04 AM.png (201×356 px, 12 KB)

After:

Screen Shot 2019-08-02 at 9.39.54 AM.png (191×349 px, 11 KB)

Diff Detail

Repository
rP Phabricator
Branch
highlight1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23222
Build 31898: Run Core Tests
Build 31897: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Aug 2 2019, 4:43 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.