Page MenuHomePhabricator

Fix an issue where lines with more than one pattern match highlighted improperly in Diffusion
ClosedPublic

Authored by epriestley on Aug 2 2019, 4:42 PM.
Tags
None
Referenced Files
F19803452: D20695.id49357.diff
Sun, Mar 1, 11:34 PM
F19658527: D20695.id.diff
Fri, Feb 6, 11:26 PM
F19570071: D20695.id49357.diff
Feb 1 2026, 12:49 AM
F19569554: D20695.id49357.diff
Feb 1 2026, 12:03 AM
F19569553: D20695.id49357.diff
Feb 1 2026, 12:02 AM
F19539663: D20695.id49358.diff
Jan 21 2026, 9:06 PM
F19539661: D20695.id49358.diff
Jan 21 2026, 9:06 PM
F19523031: D20695.diff
Jan 17 2026, 12:45 PM
Subscribers
None

Details

Summary

Ref T13339. If a search pattern matches more than once on a line, we currently render the line incorreclty, duplicating some of the text.

substr() is being called as though the third parameter was end_offset, but it's actually length. Correct the parameter.

Test Plan

Before:

Screen Shot 2019-08-02 at 9.40.04 AM.png (201×356 px, 12 KB)

After:

Screen Shot 2019-08-02 at 9.39.54 AM.png (191×349 px, 11 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Aug 2 2019, 4:43 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.