Page MenuHomePhabricator

Fix an issue where lines with more than one pattern match highlighted improperly in Diffusion
ClosedPublic

Authored by epriestley on Aug 2 2019, 4:42 PM.
Tags
None
Referenced Files
F12847676: D20695.id49358.diff
Fri, Mar 29, 2:35 AM
Unknown Object (File)
Thu, Mar 21, 6:13 PM
Unknown Object (File)
Sat, Mar 9, 11:41 PM
Unknown Object (File)
Feb 15 2024, 1:45 AM
Unknown Object (File)
Feb 7 2024, 10:13 PM
Unknown Object (File)
Dec 24 2023, 5:42 AM
Unknown Object (File)
Dec 23 2023, 3:13 AM
Unknown Object (File)
Dec 19 2023, 3:43 PM
Subscribers
None

Details

Summary

Ref T13339. If a search pattern matches more than once on a line, we currently render the line incorreclty, duplicating some of the text.

substr() is being called as though the third parameter was end_offset, but it's actually length. Correct the parameter.

Test Plan

Before:

Screen Shot 2019-08-02 at 9.40.04 AM.png (201×356 px, 12 KB)

After:

Screen Shot 2019-08-02 at 9.39.54 AM.png (191×349 px, 11 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Aug 2 2019, 4:43 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.