Paths

Table of Contentst

Differential D20660

In Ferret, allow documents with no title to match query terms by using LEFT JOIN on the "title" ranking field
ClosedPublic
Actions

Authored by epriestley on Jul 18 2019, 5:22 PM.

Tags

None

Referenced Files

	F14843685: D20660.id49284.diff
	Sun, Feb 2, 9:01 AM

	F14843640: D20660.id49286.diff
	Sun, Feb 2, 8:37 AM

	F14843029: D20660.diff
	Sun, Feb 2, 3:24 AM

	F14841219: D20660.id.diff
	Sat, Feb 1, 1:10 PM

	Unknown Object (File)
	Thu, Jan 23, 5:37 AM

	Unknown Object (File)
	Wed, Jan 22, 3:03 PM

	Unknown Object (File)
	Tue, Jan 21, 1:02 PM

	Unknown Object (File)
	Sun, Jan 19, 6:18 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T13345: Ferret does not match documents with no title

Commits

rPcb4add311649: In Ferret, allow documents with no title to match query terms by using LEFT…

Summary

Fixes T13345. See D20650. Currently, PhabricatorCursorPagedPolicyAwareQuery does a JOIN against the "title" field so it can apply additional ranking/ordering conditions to the query.

This means that documents with no title (which don't have this field) are always excluded from the result set.

We'd prefer to include them, just not give them any bonus ranking/relevance boost. Use a LEFT JOIN so they get included.

Test Plan

Applied D20650 (diff 1), made it use raw getTitle() as the document title, indexed a paste with no title.
Searched for a term in the paste body.
Before change: no results.
After change: found result.

Screen Shot 2019-07-18 at 10.18.32 AM.png (664×1 px, 85 KB)

Diff Detail

Repository

Branch

query1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23151
Build 31793: Run Core Tests
Build 31792: arc lint + arc unit

Event Timeline

epriestley created this revision.Jul 18 2019, 5:22 PM

Harbormaster completed remote builds in B23151: Diff 49284.Jul 18 2019, 5:23 PM

epriestley requested review of this revision.Jul 18 2019, 5:23 PM

amckinley accepted this revision.Jul 18 2019, 5:27 PM

This revision is now accepted and ready to land.Jul 18 2019, 5:27 PM

Closed by commit rPcb4add311649: In Ferret, allow documents with no title to match query terms by using LEFT… (authored by epriestley). · Explain WhyJul 18 2019, 5:37 PM

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPcb4add311649: In Ferret, allow documents with no title to match query terms by using LEFT….

epriestley mentioned this in D20650: Add Ferret support to Paste.Apr 16 2020, 8:56 PM

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

query/

policy/

PhabricatorCursorPagedPolicyAwareQuery.php

14 lines

Diff 49284

src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php

Loading...