Page MenuHomePhabricator

Make "bin/files" parsing of working set arguments more consistent
ClosedPublic

Authored by epriestley on Jun 24 2019, 10:13 PM.
Tags
None
Referenced Files
F15588160: D20614.id49176.diff
Fri, May 9, 5:02 AM
F15584491: D20614.id.diff
Thu, May 8, 4:01 AM
F15581705: D20614.diff
Wed, May 7, 12:35 PM
F15555129: D20614.id49176.diff
Mon, Apr 28, 10:01 AM
F15518018: D20614.id49179.diff
Sat, Apr 19, 10:14 AM
F15507884: D20614.diff
Tue, Apr 15, 11:45 PM
F15488694: D20614.id49179.diff
Fri, Apr 11, 1:38 AM
F15487701: D20614.id49176.diff
Thu, Apr 10, 4:20 PM
Subscribers
None

Details

Summary

Fixes T13326. In D20571, I slightly generalized construction of an iterator over a set of files, but missed some code in other "bin/files ..." commands which was also affected.

Today, basically all of these workflows define their own "--all" and "names" flags. Pull these definitions up and implement them more consistently.

Test Plan

Ran multiple different bin/files commands with different combinations of arguments, saw consistent handling of iterator construction.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable